C#: Replace RewriteRule/IRewriteRule with Rewriter class#7128
Closed
knutwannheden wants to merge 1 commit intomainfrom
Closed
C#: Replace RewriteRule/IRewriteRule with Rewriter class#7128knutwannheden wants to merge 1 commit intomainfrom
knutwannheden wants to merge 1 commit intomainfrom
Conversation
…ttern.RewriteTo()
Simplify the rewrite API by removing vocabulary ("rule") that conflicts
with the existing pattern/template/visitor/recipe terminology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Feedback from the team is that "RewriteRule" introduces vocabulary ("rule") that's at odds with the existing pattern/template/visitor/recipe terminology. The API should build naturally on
CSharpPatternandCSharpTemplatewithout introducing new top-level concepts.Examples
Summary
CSharpPattern.RewriteTo(CSharpTemplate)returning a newRewriterclassRewriterhasTryOn(),ToVisitor(), and staticCreateBlockFlattener<P>()— same implementation as the oldRewriteRuleImpl/RewriteRuleVisitorIRewriteRuleinterface andRewriteRulestatic factory classRewriteRuleTests.cs→RewriterTests.csand update all recipe implementationsTest plan
dotnet buildsucceeds with no errors